Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS and GO_FLAGS Makefile vars cannot be set from command line #507

Closed
jsanda opened this issue Mar 8, 2021 · 1 comment
Closed

TESTS and GO_FLAGS Makefile vars cannot be set from command line #507

jsanda opened this issue Mar 8, 2021 · 1 comment
Assignees
Labels
bug Something isn't working complexity:low
Projects

Comments

@jsanda
Copy link
Contributor

jsanda commented Mar 8, 2021

Bug Report

Describe the bug
The TESTS and GO_FLAGS variables were introduced to give more control over unit test execution, but they currently cannot be set from the command line.

To Reproduce
Steps to reproduce the behavior:

  1. Run GO_FLAGS="-v" TESTS=".*auth.*" make unit-test
  2. All unit tests are run with non-verbose output

Expected behavior
I should be able to set these vars from the command line.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Helm charts version info

1.0.0

  • Helm charts user-supplied values

$ helm get values RELEASE_NAME

  • Kubernetes version information:

kubectl version

  • Kubernetes cluster kind:

Additional context

@jsanda jsanda added bug Something isn't working complexity:low labels Mar 8, 2021
@jsanda jsanda self-assigned this Mar 8, 2021
@jsanda jsanda added this to Development Backlog in K8ssandra via automation Mar 8, 2021
@jsanda
Copy link
Contributor Author

jsanda commented Mar 8, 2021

Closing since this is not a bug.

@jsanda jsanda closed this as completed Mar 8, 2021
K8ssandra automation moved this from Development Backlog to Done Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complexity:low
Projects
No open projects
K8ssandra
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant