Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics to the rewrite #127

Closed
Kidswiss opened this issue Oct 30, 2020 · 4 comments · Fixed by #146
Closed

Add prometheus metrics to the rewrite #127

Kidswiss opened this issue Oct 30, 2020 · 4 comments · Fixed by #146
Assignees

Comments

@Kidswiss
Copy link
Contributor

The rewrite currently doesn't contain any k8up metrics.

The operator-sdk provides a default metrics endpoint though. So use that one to add the custom metrics, if possible.

Most metrics are defined in the observer or the scheduling in the old version:
https://github.com/vshn/k8up/blob/master/service/schedule/scheduleRunner.go#L30
https://github.com/vshn/k8up/blob/master/service/observe/subscription.go#L23

With #114 merged the new implementation lives on the development branch.

@susana-garcia
Copy link
Contributor

susana-garcia commented Nov 11, 2020

I'll take this one

@susana-garcia
Copy link
Contributor

@Kidswiss quick question related to this task: what’s the best way to setup prometheus in my local cluster for dev mode?

@Kidswiss
Copy link
Contributor Author

@susana-garcia I usually just curl'd the /metrics endpoint to see if the metrics show up. As they are plain text it's pretty easy to verify that way.

@susana-garcia
Copy link
Contributor

@Kidswiss ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants