feat(http_server): add max_request and max_request_grace configuration options #220
Conversation
|
@luca-nardelli Thanks, it looks ok to me. Just wondering if we shouldn't prefix those options with: You can also add them to the https://github.com/k911/swoole-bundle/blob/develop/docs/configuration-reference.md Currently, there are no unit tests for configuration component and since there is a major refactor going on on feature branch - so I'm fine with changes |
k911
added
area/config
area/docs
area/symfony-bundle
kind/feature
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
=============================================
- Coverage 87.19% 87.09% -0.10%
- Complexity 604 612 +8
=============================================
Files 84 84
Lines 1858 1883 +25
=============================================
+ Hits 1620 1640 +20
- Misses 238 243 +5
|
|
Hey, the prefix seems like a good idea to me as it makes the options clearer to understand. I should have updated the PR with the prefix and with the documentation update as well |
|
Edit: I changed the node definition for worker_max_request_grace to scalarNode so that we can support null as well (with integerNode this was not supported) |
…e configuration options
|
Forgot to ran |
|
Code Climate has analyzed commit 2585564 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 84.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.0% (0.0% change). View more on Code Climate. |
|
@luca-nardelli Thanks for this contribution, I'll release this soon |
* fix(server): add worker_max_request and worker_max_request_grace configuration options (#220) ([69fd435](69fd435)), closes [#220](#220) * build(deps-dev): bump phpstan/phpstan from 0.12.19 to 0.12.20 (#212) ([d2ca5ea](d2ca5ea)), closes [#212](#212) * build(deps-dev): bump swoole/ide-helper from 4.4.17 to 4.5.0 (#197) ([021b84a](021b84a)), closes [#197](#197)
Hi @k911,
First of all, many thanks for the amazing bundle!
I needed to set the
max_requestandmax_request_graceoptions from the bundle configuration so I thought of adding them.I couldn't find any tests related to the configuration parsing and passing to Swoole, should I create one? If so, should I just test the HttpServerConfiguration class or should I also test parsing from Symfony's side?
Let me know, thanks!