Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Profiler toolbar doesn't collect logs #241

Closed
Rastusik opened this issue Jun 5, 2020 · 3 comments · Fixed by #242
Closed

Profiler toolbar doesn't collect logs #241

Rastusik opened this issue Jun 5, 2020 · 3 comments · Fixed by #242
Assignees
Projects

Comments

@Rastusik
Copy link
Contributor

Rastusik commented Jun 5, 2020

Describe the bug
Symfony profiler (debug toolbar) doesn't collect logs with symfony-swoole

Steps To Reproduce
Enable the profiler toolbar and try to log something during a profiled request. When going to the request profile from the toolbar, the Logs menu item doesn't contain any data.

Expected behavior
There should be data in the logs menu item.

@Rastusik Rastusik added kind/bug/possible Something probably isn't working priority/important labels Jun 5, 2020
@k911
Copy link
Owner

k911 commented Jun 5, 2020

Can you explain further why do you think it is a swoole-bundle bug?

Also, please try using 1 worker or enabling session storage, my guess is that it relies on that. If not please provide at least some logs and a minimal reproducible example.

@k911 k911 added this to Needs triage in Bugs via automation Jun 5, 2020
@Rastusik
Copy link
Contributor Author

Rastusik commented Jun 5, 2020

It is a Symfony bug, I already have a fix for this, I'm just playing with it a little more. This bug doesn't have anything to do with session storage.

@Rastusik
Copy link
Contributor Author

Rastusik commented Jun 5, 2020

/**
 * This is an override for Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddDebugLogProcessorPass
 * which removes debug processor from loggers when Symfony is run from CLI.
 * Without debug log processor, there are no logs being shown in the symfony profiler. This override
 * replaces the original configurator for 'monolog.logger_prototype' with a custom one, which removes
 * the debug log processor only when being run from PHPDBG.
 */

@k911 k911 moved this from Needs triage to High priority in Bugs Jun 12, 2020
@k911 k911 added kind/bug/confirmed Something isn't working priority/important and removed kind/bug/possible Something probably isn't working status/waiting-for-contributor labels Jun 12, 2020
@k911 k911 closed this as completed in #242 Jun 15, 2020
Bugs automation moved this from High priority to Closed Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Bugs
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants