Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

feat(apiserver): Create API Server component #32

Merged
merged 1 commit into from
Apr 6, 2019
Merged

feat(apiserver): Create API Server component #32

merged 1 commit into from
Apr 6, 2019

Conversation

k911
Copy link
Owner

@k911 k911 commented Feb 28, 2019

API Server component will allow to manage Swoole HTTP Server trough HTTP interface.

Command swoole:server:status is added to get informations about currently running HTTP server.

Closes #2

@k911 k911 self-assigned this Feb 28, 2019
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServer.php Outdated Show resolved Hide resolved
@k911 k911 added this to In progress in Development Feb 28, 2019
@k911 k911 force-pushed the apiserver branch 2 times, most recently from 670759c to 4801bb1 Compare March 16, 2019 18:14
@k911 k911 force-pushed the apiserver branch 3 times, most recently from 8bca571 to a13ae57 Compare March 17, 2019 13:16
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Bridge/Symfony/Bundle/Command/ServerStatusCommand.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Bridge/Symfony/Bundle/Command/ServerStatusCommand.php Outdated Show resolved Hide resolved
src/Bridge/Symfony/Bundle/Command/ServerStatusCommand.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Show resolved Hide resolved
src/Server/Api/ApiServer.php Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Show resolved Hide resolved
src/Server/Api/WithApiServerConfiguration.php Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
@k911 k911 force-pushed the apiserver branch 3 times, most recently from 85ba2b3 to e2eae04 Compare March 18, 2019 23:58
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerClient.php Outdated Show resolved Hide resolved
src/Server/Api/ApiServerRequestHandler.php Show resolved Hide resolved
@k911 k911 force-pushed the apiserver branch 2 times, most recently from 17bd6e4 to 0591ece Compare March 19, 2019 00:25
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #32 into develop will decrease coverage by 0.21%.
The diff coverage is 79.19%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #32      +/-   ##
=============================================
- Coverage      82.76%   82.55%   -0.22%     
- Complexity       345      428      +83     
=============================================
  Files             47       54       +7     
  Lines           1056     1341     +285     
=============================================
+ Hits             874     1107     +233     
- Misses           182      234      +52
Impacted Files Coverage Δ Complexity Δ
src/Client/Http.php 0% <0%> (ø) 1 <1> (?)
src/Server/HttpServerFactory.php 100% <100%> (ø) 2 <2> (+1) ⬆️
src/Server/Api/WithApiServerConfiguration.php 100% <100%> (ø) 5 <5> (?)
...mfony/Bundle/DependencyInjection/Configuration.php 100% <100%> (ø) 8 <0> (+3) ⬆️
...fony/Bundle/Command/AbstractServerStartCommand.php 84.92% <100%> (+2.35%) 30 <2> (+5) ⬆️
...ony/Bundle/DependencyInjection/SwooleExtension.php 81.98% <100%> (+12.45%) 33 <0> (+1) ⬆️
src/Server/Api/ApiServer.php 28.57% <28.57%> (ø) 8 <8> (?)
...erver/Configurator/WithHttpServerConfiguration.php 85.71% <50%> (ø) 3 <0> (ø) ⬇️
src/Server/Api/ApiServerRequestHandler.php 62.31% <62.31%> (ø) 24 <24> (?)
src/Server/Config/Sockets.php 68.18% <68.18%> (ø) 10 <10> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7271cf8...c62b55c. Read the comment docs.

@k911 k911 force-pushed the apiserver branch 2 times, most recently from 7bd7632 to 90d70e5 Compare March 19, 2019 22:17
@k911 k911 force-pushed the apiserver branch 2 times, most recently from 5e08003 to 140c353 Compare April 6, 2019 13:19
@k911 k911 changed the title feat(api-server): Create API Server component feat(apiserver): Create API Server component Apr 6, 2019
@k911 k911 force-pushed the apiserver branch 3 times, most recently from cc445ef to 5a6fe61 Compare April 6, 2019 13:52
@k911 k911 force-pushed the apiserver branch 3 times, most recently from e8f7804 to ca1345b Compare April 6, 2019 14:50
API Server component will allow to manage Swoole HTTP Server trough HTTP interface
@codeclimate
Copy link

codeclimate bot commented Apr 6, 2019

Code Climate has analyzed commit c62b55c and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Clarity 3

Note: there are 2 critical issues.

The test coverage on the diff in this pull request is 77.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.9% (-0.6% change).

View more on Code Climate.

@k911 k911 merged commit a8d0ec2 into develop Apr 6, 2019
Development automation moved this from In progress to Done Apr 6, 2019
@k911 k911 deleted the apiserver branch April 6, 2019 15:13
This was referenced Apr 6, 2019
k911 pushed a commit that referenced this pull request Apr 26, 2019
##  (2019-04-26)

* refactor: Replace foreach loop with `yield from` expression ([8744f30](8744f30))
* refactor(http-client): Decouple components of Http clients ([eb60f5b](eb60f5b))
* refactor(pid): Rename "pid_file" option to "pid-file" (#42) ([2a234c3](2a234c3)), closes [#42](#42)
* build(docker): Gather code coverage from tests running in containers ([12084e1](12084e1))
* build(docker): Parametrize image tags ([80bb0a8](80bb0a8))
* build(docker): Provide configuration for testing ([d4f630a](d4f630a))
* build(docker): Use "pcov" instead of "xdebug" as code coverage engine ([4284ed3](4284ed3))
* ci(circle): Add build to matrix with latest version of swoole ([af17b96](af17b96))
* ci(circle): Configure Docker layer cache ([6ec5731](6ec5731))
* ci(circle): Detect latest swoole version using pecl website ([1e83b4c](1e83b4c))
* ci(circle): Fix cache key in save cache step ([ec1c1d9](ec1c1d9))
* ci(circle): Optimize caching keys ([6fd1872](6fd1872))
* ci(circle): Set-up commitlint (#36) ([8fc4a0c](8fc4a0c)), closes [#36](#36)
* ci(circleci): Add shellcheck step ([b086620](b086620))
* ci(codeclimate): Enable "shellcheck" ([7271cf8](7271cf8))
* ci(travis): Add separate builds with latest swoole and updated composer packages ([6a22070](6a22070))
* ci(travis): Enable CodeCov reporting ([35eb034](35eb034))
* ci(travis): Fix usage of CodeClimate on Pull Request ([741cd3e](741cd3e))
* ci(travis): Increase retries count for code coverage tests ([853f0a7](853f0a7))
* ci(travis): Remove code coverage step ([0292a43](0292a43))
* ci(travis): Switch "travis_retry" to custom bash script ([1f1de2a](1f1de2a))
* ci(travis): Switch distro to ubuntu xenial (#38) ([1d7a65c](1d7a65c)), closes [#38](#38)
* ci(travis): Use swoole v4.3.1 ([dbd240a](dbd240a))
* chore(deps): Upgrade dependencies ([f4580a0](f4580a0))
* chore(deps): Upgrade dependencies ([0bed9e9](0bed9e9))
* chore(deps): Upgrade dependencies ([270b95b](270b95b))
* chore(deps): Upgrade dependencies ([ab745c8](ab745c8))
* chore(ide-helper): Switch to official swoole package (#49) ([c87cbc8](c87cbc8)), closes [#49](#49)
* chore(phpstan): Ignore wrong reports of callable arguments ([d129105](d129105))
* test: Add InotifyHMR test ([e76729a](e76729a))
* test(code-coverage): Gather code coverage from server processes ([d6ef146](d6ef146))
* test(commands): Ensure symfony commands are registered correctly ([d3abbc1](d3abbc1))
* test(feature): Create feature tests suite ([e27d48f](e27d48f))
* test(mock): Fix Swoole Server mocks (#48) ([a93ac48](a93ac48)), closes [#48](#48)
* test(xdebug-handler): Test restarting process when xdebug enabled ([740af84](740af84))
* feat: Add meaningful exceptions (#46) ([4e2cc6d](4e2cc6d)), closes [#46](#46)
* feat(apiserver): Create API Server component (#32) ([a8d0ec2](a8d0ec2)), closes [#32](#32) [#2](#2)
* feat(server): Add setting for "buffer_output_size" (#33) ([7a50864](7a50864)), closes [#33](#33)
* feat(server): Set-up hooks on lifecycle events ([271a341](271a341))
* fix(di): Do not use integer node for port ([ac6fdcf](ac6fdcf))
* fix(hmr): Drop unused reference to SymfonyStyle object in InotifyHMR ([6b22485](6b22485))
* fix(reload): Make sure command works on macOS system ([4d99e9c](4d99e9c))
@k911 k911 removed the status/wip Work in progress label Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Add more commands
2 participants