Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Is that a good idea to make the default host from 'localhost' to '0.0.0.0'? #54

Closed
CoderChang65535 opened this issue May 5, 2019 · 4 comments · Fixed by #55
Closed
Labels

Comments

@CoderChang65535
Copy link
Contributor

I think using '0.0.0.0' as default value can be much better than 'localhost' because it contains '127.0.0.1' or 'localhost' and is easy to expose without any configuration.

@k911 k911 added area/config kind/question Further information is requested priority/important labels May 5, 2019
@k911
Copy link
Owner

k911 commented May 5, 2019

Yes, @CoderChang65535 it think this is reasonable setting. Would you like to prepare a pull request, then?

@CoderChang65535
Copy link
Contributor Author

Thanks and I'm glad to do that. I will do it later.

@CoderChang65535
Copy link
Contributor Author

Hi, @k911 .
I'm not sure what commit message I should set as the style as the conventional-changelog?
Could you give some help for that?
Is that the one you like:
feat(config): set default host value to '0.0.0.0'

@k911
Copy link
Owner

k911 commented May 6, 2019

It's more like fix I think, because using localhost as default means 0.0.0.0 does not work and users might expect to work this out of the box in e.g. docker container.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants