Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXE in WebDavStore #3681

Closed
prodigysml opened this issue Oct 24, 2018 · 1 comment
Closed

XXE in WebDavStore #3681

prodigysml opened this issue Oct 24, 2018 · 1 comment
Labels
type: bug Something is causing incorrect behavior or errors

Comments

@prodigysml
Copy link

prodigysml commented Oct 24, 2018

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred

The following code snippets display the usage of saxparserfactory without securely disabling entities:
https://github.com/k9mail/k-9/blob/18aee1b92c902dc5e98d89045e09919adf483b4a/mail/protocols/webdav/src/main/java/com/fsck/k9/mail/store/webdav/WebDavStore.java#L943

Remediation

https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet

@cketti cketti added the type: bug Something is causing incorrect behavior or errors label Mar 8, 2019
@cketti
Copy link
Member

cketti commented Oct 6, 2020

Obsolete because WebDAV support will be removed. See #4251.

@cketti cketti closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

2 participants