fix flicker of subject line in MessageHeader #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -275,7 +274,7 @@ public void populate(final Message message, final Account account) throws Messag | |||
| * or the device is rotated. | |||
There was a problem hiding this comment.
Comment needs to be updated or removed.
MessageHeader rendered the subject line by default, and only after MessageTitleView decided it was large enough to display the entire subject line, the subject line was hidden again. This caused a noticable flicker during message rendering while navigating with next/previous message buttons. This commit flips the logic, only displaying the subject view once the title view finds it can't display it all.
Valodim
force-pushed
the
messageview-fix-flicker
branch
from
1154b41
to
27a3add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageHeader rendered the subject line by default, and only after
MessageTitleView decided it was large enough to display the entire
subject line, the subject line was hidden again. This caused a noticable
flicker in vertical size during message rendering while navigating with
next/previous message buttons.
This commit flips the logic, only displaying the subject view once the
title view finds it can't display it all.