Rewrite expunge #2701
Closed
Rewrite expunge #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
June 12, 2017 11:17
rhari991
force-pushed
the
rewrite-imap-expunge
branch
from
1dcbaa7
to
16aef39
Compare
rhari991
force-pushed
the
rewrite-imap-expunge
branch
from
16aef39
to
536b1a8
Compare
Valodim
reviewed
Aug 24, 2017
|
|
||
| uidExpungeCommand.execute(connection, this); | ||
| } else { | ||
| UidSearchCommand searchCommand = new UidSearchCommand.Builder() |
There was a problem hiding this comment.
I think this warrants its own method. also, a reference to the rfc would be nice, since this type of fallback method from a spec is not very common
There was a problem hiding this comment.
...I don't think so, actually?
There was a problem hiding this comment.
I have moved the UidSearchCommand and it's execution into a new method getUnknownDeletedUids() and have added a comment regarding the RFC at the top of the try block
There was a problem hiding this comment.
oh, I see. I meant the whole thing in the else block, maybe something like expungeWithoutUidPlus?
rhari991
force-pushed
the
rewrite-imap-expunge
branch
from
536b1a8
to
5ac3367
Compare
rhari991
force-pushed
the
rewrite-imap-expunge
branch
from
5ac3367
to
9654cf3
Compare
rhari991
force-pushed
the
gsoc-2017-rhari991
branch
4 times, most recently
from
39156ee
to
524d8ba
Compare
Merged
|
Rebased in #2927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
expunge()method inImapFolderto ensure that only messages that were marked with the\Deletedflag by K-9 Mail are expunged. This process is described in section 4.2.4 of RFC 4549