Add XOAUTH2 support for gmail and outlook #4832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally a free and easy to use solution for Xoauth2. |
|
@starshipcoder: Thanks for the pull request. This is quite a substantial change and not something I want to merge (or even look at in detail) before releasing a new stable version of the app. So it might be a while before I get to this. |
|
Any chance that this request will be merged in the near future? There are a lot of users waiting for OAUTH support. |
|
Just a curious question: What's the usual turn-around time for this to appear in Google Play Store? Such important feature. :) |
|
Hi starshipcoder, When setting up the account, the password prompt disappears I then get an ssl failure when connecting Finally, the account is still created despite the ssl failure Thanks, |
|
Hi Poldi It is normal the password field disapear as in XOauth2, the passsword is set later in a trust webview I think you need to create google credentials for testing with gmail In this page you need to create a OAuth 2.0 Client IDs And then put the id in your local.properties debugGmailClientId=your_id.apps.googleusercontent.com You should see this webview if it works
Regards |
|
Hi starshipcoder, This is what I have in /mail/common/build.cradle `buildConfigField "String", "GOOGLE_CLIENT_ID", """+getDebugGmailClientId()+""" def getDebugGmailClientId() { This is what I have in local.properties
|
|
I've added the id to my local.properties and am now getting this error
My client config looks like this
|
|
Hi Poldi As you are in debug, the package name should be com.fsck.k9.debug I hope it help Regards |
|
I've added the id to my local.properties and am now getting this error
My client config looks like this
|
|
Wow, works as expected. |
|
@poldi171254: can you please briefly summarize what you did that it now works? Thank you very much! |
|
Go to
Create a new project. It doesn't matter what you call it. Create consent Provide application info (you can leave all non-required fields empty). Again, it doesn't realy matter what name you choose for testing Save scopes (no input required on this screen) and continue Add your test user(s) And then put the id in your local.properties debugGmailClientId=your_id.apps.googleusercontent.com Cheers, |
|
@poldi171254 Great, thank you very much! |
|
Ping. Just curious where this stands. Super excited and appreciate all the work being done on it! |
|
Rebased version of this pull request is available as #5385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is a refactor of the code for xoauth2 in GSOC_account_setup branch.
It manage only one method to obtain access token: the Authorization Code Grant.
It don't manage token from google device account.
It could be easily test with an outlook/hotmail account, for gmail it needs credentials for debug and release.