Player model animations are broken

[Wuzzy2]

The walking and other animations of the player looks very strange. If you walk, the animation looks like it very quickly “resets” which looks pretty buggy. I think the idle animation does not really play for the same reason.

And if you look closely at the wielditem (of the player model), you will notice that it heavily flickers.

Interestingly, the idle animation does play if you go into pause mode in singleplayer.

[kaadmy]

I'm still not sure about the player model animation, it's been buggy since 0.4.14, and minetest_game's player model still looks good for some reason.

[Wuzzy2]

I just discovered that Pixture spams the console with this:

2016-11-14 01:06:35: WARNING[Main]: Irrlicht: Could not open file of texture: character.png
2016-11-14 01:06:35: WARNING[Main]: Irrlicht: Could not open file of texture: character.png
2016-11-14 01:06:35: WARNING[Main]: Irrlicht: Could not open file of texture: character.png
2016-11-14 01:06:35: WARNING[Main]: Irrlicht: Could not open file of texture: character.png
2016-11-14 01:06:35: WARNING[Main]: Irrlicht: Could not open file of texture: character.png

Repeated endlessly. Note the time. Ironically, it is not the player texture which causes problems, this looks just fine.

In the inventory menu, the spam changes to this:

Could not open file of texture: character.png
Loaded mesh: character.b3d
Could not open file of texture: character.png
Loaded mesh: character.b3d

Again, repeated forever. Could it be that your code attempts to load or set the player model mesh again and again every tick? This looks like some code is going crazy here, being repeated so often.

Tested in: 7f6b732

Maybe it helps if you strip all player model logic from default. I have released a standalone mod playermodel which only provides the player model; it is simply the player model extracted from default. I did this to make life of subgame authors easier.

[kaadmy]

I think this is an issue with Irrlicht/Minetest where it tries to load the image in textures/ AND models/, because this issue is fixed by moving the texture into models.

[asl97]

@Wuzzy2 The spam is an issue with Irrlicht, I created a pull request for that at #36

The issue with the animation seem to be because the set_nametag_attributes reset the animation.
I created another pull request for that at #37