Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with LaunchImage on xcassets #4

Closed
filipealva opened this issue Oct 13, 2015 · 4 comments
Closed

Not working with LaunchImage on xcassets #4

filipealva opened this issue Oct 13, 2015 · 4 comments

Comments

@filipealva
Copy link

Hey,

It does not works when the project has a LaunchImage. It creates the following code for LaunchImage:

public enum LaunchImage.launchimage {
}

which causes a build time crash.

@kaandedeoglu
Copy link
Owner

@filipealva Hey there,
thanks for spotting that, looks like a very serious mistake on my part!

I'll fix it today and push a fix

Just to be on the same page, Shark will ignore all LaunchImage imagesets (as it does for AppIcon imagesets) - is that okay for you?

@filipealva
Copy link
Author

@kaandedeoglu Nice! Yes, its ok to ignore all LaunchImage on assets.

Congrats about the project, and thank you for the fast feedback 👍

@kaandedeoglu
Copy link
Owner

@filipealva I just released version 0.1.1 and it's ready to use through Cocoapods or manually.

I'm leaving this open until you confirm that everything works as expected. Please let me know when you try - again, thanks for reaching out 👍

@filipealva
Copy link
Author

@kaandedeoglu I tried right now, it is working properly!

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants