-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcement CaseIterable
needs to be optional
#48
Comments
CaseIterable
needs to be an optionalCaseIterable
needs to be optional
I'm not sure I understand that. The nesting is independent from the attribute |
hey there @mickeyl! thanx for the response! tbh do not even know how to show the entire thing, will share a screenshot with some parts of the diff so you have a better idea So we used to have all the resources separated in folders, on that screenshot you see the deleted parts of previously generated enum for images And now all the resources are just under one resource specific enum ( |
So if we take for example the very first case from the screenshot with deleted parts, Imho previous approach was better especially for the projects with tons of different resources, was way easier to navigate and find resources case enums reflected the folder structure in resources. |
@404wasfound Ah, I think this is due to the new corrected folder handling. Please have a look at the README again. If you want Shark to turn a folder into a namespace, you need to check the [x] Provides Namespace below for every folder you're using. Previously, Shark did create a namespace for every folder, no matter whether the checkbox was ticked or not. The new behavior is correct, although it requires you to adjust your projects. Sorry for the inconvenience. Please check after checking the folder checkboxes whether this returns your Shark file to the previous state. |
ooohhhh now I see ... so the previous folders handling was not correct? will try it now, thank you for the info and sorry for bothering! |
@mickeyl worked, thank you very much! |
By making all the enums
CaseIterable
you essentially breaking all the projects which have their resources separated in different folders, cause now all the resources of the same type are under one huge enum, instead of the nested ones. Have to fork the tool to fix it now.The text was updated successfully, but these errors were encountered: