-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Make it work with React Query v4 #60
Comments
hello @kaciakmaciak is the issue solved? |
i want to use the lib with react query v4? |
Hi, this is almost done, just a few tests are failing, but the examples look to work fine. So I need to figure out if the tests are failing because there is a regression or because of tests are written in a wrong way. |
The associated branch https://github.com/kaciakmaciak/react-query-subscription/tree/react-query-v4 I might release a beta version, to test in your project. |
The |
Any feedback on beta version 👆 used with react query v4, please? |
I'm using it successfully with react-query v4, thanks a lot for having published the beta. A couple comments regarding the documentation for the example using graphql-ws:
Looking at the type I realized it's expecting an array. Using
fromWsClientSubscription<{ comments: Array<Comment> }>(
client, // <-- this needs to be added
{
query: ... |
Hey there I have a weird bug here, I've updated the package to the I'm using NextJS 13 (without the
and pasted on my project, after that I imported the Since my project is kinda big right now, I thought that I could have some weird config, so I created a fresh one and the problem and "solution" was the same. I will leave the minimal reproducible repo here and also a CodeSandbox, the dependencies version and everything else are the same as my original project (I can't share it). I left some basic instructions at the readme, but if you clone and run the dev server you will get the I'm not sure what is causing, but a wild guess would be that maybe it's something related to the bundle itself that it's missing something |
Make
react-query-subscription
compatible withreact-query@4
.Build
Needs to be fixed
cancelRefetch
#69onSuccess
is no longer called fromsetQueryData
#67cancel
method on promises is no longer supported (v4) #73Need to be fixed for dev/tests
setLogger
is removed (v4)Consider for the future
fetchStatus
The text was updated successfully, but these errors were encountered: