Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIP15: User Rejects CommandSigData -> noSig or failure? #41

Open
Luzzotica opened this issue Apr 4, 2023 · 0 comments
Open

KIP15: User Rejects CommandSigData -> noSig or failure? #41

Luzzotica opened this issue Apr 4, 2023 · 0 comments

Comments

@Luzzotica
Copy link
Contributor

Luzzotica commented Apr 4, 2023

Hypothetical situation:

3 CommandSigDatas are sent and the wallet.
The user signs 2 of them and rejects the last one.
Should the wallet respond with noSig for the last CommandSigData?
I feel that sometimes there might be a noSig just because the wallet doesn't have a private key for any of the listed public keys. Should the dApp expect the same behavior for both?
Or perhaps the wallet should respond with failure if the user rejects the request?

Can we perhaps add some clarity to how the wallet should respond in the above situation?

For now, I will use failure so I can provide feedback in the msg field.

@Luzzotica Luzzotica changed the title KIP15: noSig KIP15: User Rejects CommandSigData -> noSig or failure? Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant