Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle price manipulation issue. #93

Open
2 of 4 tasks
0xSandyy opened this issue Jun 14, 2024 · 4 comments
Open
2 of 4 tasks

Add oracle price manipulation issue. #93

0xSandyy opened this issue Jun 14, 2024 · 4 comments

Comments

@0xSandyy
Copy link
Contributor

Checklist

  • I have searched the existing issues and pull requests for duplicates.

Type of Issue

  • New vulnerability addition
  • Feature request
  • Update existing vulnerability

Description

Oracles are widely used by smart contract to retrieve off-chain data. I would like to create an issue which focuses on how oracle price manipulation can occur(mainly flash loans) and some ways / best practices to mitigate the issue.

Additional Information

This issue might include a lot of DeFi terminologies like liquidity pools, flash loans, Amms, token price, etc. I would try to make this issue as simple as possible.

@indeqs
Copy link
Contributor

indeqs commented Jun 15, 2024

While the proposed issue on oracle price manipulation via flash loans is undoubtedly important, it may not be well-suited for the repository due to its specialized nature within the DeFi ecosystem. The primary focus of the repository is on smart contract vulnerabilities, and the suggested topic requires a deeper understanding of DeFi-specific mechanisms, which might be outside the core knowledge base of the repository's intended audience.

Maybe a separate branch to focus on DeFi specific vulns. But come to think of it, does it mean that we also create another branch if we want to focus on vulns related to RWA's, Decentralized Insurance etc...

We should just focus on general smart contract issues IMO

@0xSandyy
Copy link
Contributor Author

Exactly! That's why I created another issue regarding exactly that.

@rakesh0x7
Copy link
Contributor

@0xSandyy, could you please check issue #27? This issue was mentioned in that.

@0xSandyy
Copy link
Contributor Author

Yeah, but 27 is an old one. Been waiting for @kadenzipfel reply on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants