PublishContext should inherit from Subscription

[mitar]

Because now is trying to mock Subscription, but not everything is there. Like _session, _subscriptionId, _idFilter and so on. I have quite some packages which extend publish handlers and use those internal values which will now not work inside SSR. Now, one option is that I manually make all of them work, or we just fix PublishContext to be more compatible with normal subscription.

[mitar]

See the issue which lead me to this: peerlibrary/meteor-reactive-publish#7

[arunoda]

Yeah. That's a good idea,
Could you send me a PR. I'm happy to take this in.

You can get the Subscription class from here: https://github.com/meteorhacks/meteorx

[mitar]

Hm, the issue is that it is not enough just to extend it, but one should also configure all fields correctly. Not sure if this is doable. Like where to get session information.

[arunoda]

Okay. That's a big project. Anyway, is there anyway we can build packages like yours without using those internals. If we can have a set of stuff we use, I think I can do something.

[mitar]

I think I found a way.

[arunoda]

Awesome. Keep me posted.

[mitar]

See #160.

[arunoda]

Hope we can close this and I merged @mitar's PR.

[SachaG]

Does this mean the issue is also fixed for FlowRouter SSR? Or just Fast Render for now?

[arunoda]

Just the FastRender. I'll do a release today.

[arunoda]

@SachaG published a new version of FlowRouter SSR.