Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "~" in pem is making mup silently fail #189

Closed
theodorDiaconu opened this issue Aug 4, 2016 · 3 comments
Closed

Using "~" in pem is making mup silently fail #189

theodorDiaconu opened this issue Aug 4, 2016 · 3 comments
Milestone

Comments

@theodorDiaconu
Copy link

theodorDiaconu commented Aug 4, 2016

module.exports = {
    servers: {
        one: {
            "host": "XXX",
            "username": "ubuntu",
            "pem": "~/.ssh/lead-aws.key"
        }
    },
// the rest
};

$ mup deploy
Building App Bundle Locally
$

It just stops. No warning. No error. No nothing.
If I make it /home/theodor/.ssh/lead-aws.key it works.
Wasted 30 minutes for this.

I also think there is an error with app path and using "~".

@theodorDiaconu theodorDiaconu changed the title Using "~" is making mup silently fail Using "~" in pem is making mup silently fail Aug 4, 2016
@twavis
Copy link

twavis commented Aug 4, 2016

+1, been searching for this for over an hour, so glad to come across this

poltak added a commit to poltak/meteor-up that referenced this issue Aug 6, 2016
- adds in new package `expand-home-dir`
- simply traverses the `servers.pem` string and expands `~` into the full homedir path, if present
- previously `path.resolve` could not handle the `~` shortcut and would cause the deploy and setup commands to fail
- fixes zodern#189
@MichaelJCole
Copy link

This also happens if there and extra space at the end:

Works on Linux:

      pem: '../../../../../../.ssh/id_rsa'

Doesn't work:

      pem: '../../../../../../.ssh/id_rsa '

@zodern zodern added this to the 1.2.2 milestone Feb 11, 2017
@zodern
Copy link
Owner

zodern commented Feb 11, 2017

Version 1.2.2 will display a message if it can not find the pem file.

@zodern zodern closed this as completed Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants