Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install additional apt-get packages in docker image if specified #71

Closed
wants to merge 14 commits into from

Conversation

ckiely91
Copy link

@ckiely91 ckiely91 commented Mar 4, 2016

Added additional option to mup.js to specify an array of apt-get package names. Based on this gist.

This will be a very useful feature to install packages such as graphicsmagick. Let me know if there are ways I can improve this!

@madushan1000
Copy link
Contributor

We already have a proposal to add hooks, #65
Which seems like a more generic feature. @arunoda @mnmtanish what do you think?

@Ben305
Copy link

Ben305 commented Mar 5, 2016

This would be very useful to install packages like graphicsmagick

+1

@yubozhao
Copy link

yubozhao commented May 4, 2016

Just wondering the status for the PR, any update?

@madushan1000
Copy link
Contributor

The recommended way to add new packages to the docker image is to build one of your own using meteorhacks/meteord base image and use that in the deployment.

@arunoda
Copy link
Collaborator

arunoda commented Aug 3, 2016

I hope we allow to change the docker image.
meteord is the base. But you could use any docker image with your own deps.
@madushan1000 I think we need to document it if it's not done.

@jbg77
Copy link

jbg77 commented Aug 5, 2016

Yes that I've done and many other people did, two methods:
-by cloning repo, then upload your image on docker hub
-by fork meteord repo, then link you github account to your docker account, and active autobuild

Conflicts:
	README.md
	src/modules/meteor/assets/templates/start.sh
	src/modules/meteor/index.js
# Conflicts:
#	.gitignore
#	src/modules/meteor/assets/templates/start.sh
#	src/modules/meteor/index.js
@zodern
Copy link
Owner

zodern commented Oct 7, 2017

@ckiely91 Thanks for working on this. Some base images use a different package manager, such as the alpine image. I would prefer a more general purpose solution where there is an array of commands in the config to run when building the docker image.

@zodern zodern closed this Oct 7, 2017
@stefanve
Copy link

stefanve commented Oct 9, 2017

I am currently using a manual "post deploy" thing to add my packages:

docker exec -it myapp bash
apt install pdftk

I have been searching for ways to do it automatically using configuration options in MUP and ended up here. Is there a way to automate that process?

@zodern
Copy link
Owner

zodern commented Nov 1, 2017

@stefanve the best way right now is to create a custom docker image with pdftk already installed.

@zodern
Copy link
Owner

zodern commented Mar 28, 2018

@stefanve an easier way will be available in the next version: #362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants