This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Fix issue with end tag style #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Good catch! Will publish a new release with this. |
roonyh
added a commit
that referenced
this pull request
Jun 22, 2016
kesne
pushed a commit
to kesne/react-storybook-addon-info
that referenced
this pull request
Jun 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "view source" section, I noticed that the end tag was always indented one level too much, and was being aligned with the children. This is because the
containerStylewas being mutated by the child<Node>components while rendering. This PR copies thecontainerStyleinto a new object when we're about to render<Node>components to prevent the child components from changing the styles from under our feet.