This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Fix wrong detection of propType when isRequired is set #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukyth
changed the title
|
Released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the example page the propType of label is detected as
other.But actually it is
string, as you can see in the screenshot from example/Button.js below.As I investigated further, I realise that whenever
isRequiredis set in the prop, the proptype will be detected asother.It's because in src/components/PropTable.js,
PropTypesMaponly store result from properties ofReact.PropTypes. And when the prop is set asisRequired, there's no match inPropTypesMap.So I need to store
type.isRequiredinPropTypesMapas well so thatisRequiredprop can be detected.