Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): use ext options from root project #23

Merged
merged 1 commit into from Jun 11, 2022
Merged

fix(build): use ext options from root project #23

merged 1 commit into from Jun 11, 2022

Conversation

zolbooo
Copy link
Contributor

@zolbooo zolbooo commented Jun 8, 2022

React Native template already provides buildToolsVersion, minSdkVersion, compileSdkVersion and targetSdkVersion ext options, so I think that build.gradle should not use SystemNavigationBar_ prefixed options. This may cause some inconsistencies in build process.

@kadiraydinli
Copy link
Owner

@zolbooo Thanks for PR.

@kadiraydinli kadiraydinli merged commit 2ceef10 into kadiraydinli:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zolbooo @kadiraydinli