Fix bug: TagView with deletableView #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TagView with deletableView will make a new line too early, since tagWidth is calculated in mistake. In line 228, there should be `+ offset + (textPaddingRight + offset)` instead of `+ textPaddingLeft + textPaddingRight`. Dynamically get PaddingLeft and PaddingRight of deletableView, so you can change it's padding in future without modify this code snippet.
|
Thanks for pr, I will handle this issue in next version. :) |
|
Yeah, also check this: KANGOD@fb906c3 line 240 of TagView.java |
|
Actually, the calculation need some improvement. Thank you for the details. |
|
I think I have to create a dev branch so that any improving code can be added easily/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagViewwithdeletableViewwill make a new line too early, sincetagWidthis calculated in mistake.In line 228, there should be
+ offset + (textPaddingRight + offset)instead of+ textPaddingLeft + textPaddingRight.Dynamically get
PaddingLeftandPaddingRightofdeletableView, so you can change it's padding in future without modify this code snippet.