Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxLv + Additional Lv Preview for Skills #24

Closed
Sunaries opened this issue Feb 21, 2017 · 2 comments
Closed

MaxLv + Additional Lv Preview for Skills #24

Sunaries opened this issue Feb 21, 2017 · 2 comments

Comments

@Sunaries
Copy link

Sunaries commented Feb 21, 2017

Hey there,

As I was trying this feature:

1

I came across a missing option. Someone was asking me if I could give the data of (MaxLv) + 2**.
I've came to the conclusion that the program only works when the skill has a maximum level of 30. The program ignores other skills that have a maximum level of 15 or 20 when choosing the + 2 option.

Example)

2
Skill: Blessed Harmony (2320013)

2

The person asked me if I could retrieve the data of this skill beyond its max level. I couldn't.
This is the reason ↓

3

The program is missing the fixLevel variable. This variable means that you cannot extend the skill level beyond the maximum level (which is 1 in this case). This can be added with orange text next to 'Undispellable (notRemoved) as 'Fixed Maximum Lv'.
There is another issue, however. The Beast Tamer class has a few skills with a maximum level of 10, 15 and even 20. The program can only recognize a maximum level of 30 which means you cannot obtain skill info beyond the maximum level of those skills.

  • Add fixLevel as 'Fixed Maximum Lv' to skill preview
  • Make it so that the program not only recognize a maximum level of 30, but other values as well.
@Kagamia
Copy link
Owner

Kagamia commented Feb 22, 2017

Technically, it's based on whether the skill has a property named 'combatOrders' and value equals 1. It's common on almost all of 4th job skills. 'MaxLevel + 2' default level is designed for CO at first.

Of course, 'MaxLevel + 2' is not the limit, you can press '+-[]' key to adjust skill level, up to maximum lv.100, if the skill could buffed by CO.

fixLevel is a flag modifier, means that the value could only be 0/1, not a specific level.

@Sunaries
Copy link
Author

Sunaries commented Feb 22, 2017

@Kagamia Ah, so the + and - keys work while you preview it. I always thought you had to press it when you had that menu in front of you. Thanks for the explanation. :)

@Sunaries Sunaries closed this as completed May 7, 2017
Lechros pushed a commit to Lechros/WzComparerR2 that referenced this issue Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants