Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructor override #95

Closed
jarektkaczyk opened this issue Oct 29, 2015 · 1 comment
Closed

constructor override #95

jarektkaczyk opened this issue Oct 29, 2015 · 1 comment
Labels

Comments

@jarektkaczyk
Copy link
Collaborator

Tried to override __construct to empty function according to this:

https://github.com/crysalead/kahlan/blob/master/src/plugin/Stub.php#L185

but apparently it's irrelevant now, since it seems not to be used anywhere in the code.

However, using magicMethods => true solved the issue, so please review the comment and I guess it would be nice to include such example in the docs http://kahlan.readthedocs.org/en/latest/stubs/#class-stubbing.

Anyway thanks for the breath of fresh air in php testing!

@jails
Copy link
Contributor

jails commented Oct 29, 2015

Good catch, fixed in 122e03a
This parameter has been removed in flavor of the following syntax 'methods' => ['__construct'] which should works for any kind of method.

Glad you like Kahlan, I'm using it since 2 years and it already saved me a lot of time.

@jails jails closed this as completed Oct 29, 2015
@jails jails added the bug label Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants