Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An exception should be thrown when receiving potentially malicious data rather than closing the connection silently #6

Closed
Kaiepi opened this issue Apr 5, 2019 · 0 comments
Closed

An exception should be thrown when receiving potentially malicious data rather than closing the connection silently #6

Kaiepi opened this issue Apr 5, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Kaiepi
Copy link
Owner

Kaiepi commented Apr 5, 2019

Net::Telnet aims to be as unopinionated as possible, therefore it should defer what should be done when this happens to the developer using the package, not deciding to close it on its own.

This is handled in Net::Telnet::Connection.parse.
@Kaiepi Kaiepi added the good first issue Good for newcomers label Apr 5, 2019
@Kaiepi Kaiepi closed this as completed in 452d425 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kaiepi