Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxVertexOutputComponents and maxFragmentInputComponents limits are too low #1

Closed
teoxoy opened this issue Dec 21, 2022 · 3 comments
Closed
Assignees

Comments

@teoxoy
Copy link
Collaborator

teoxoy commented Dec 21, 2022

The WebGPU spec requires maxInterStageShaderVariables to be at least 16; that means that maxVertexOutputComponents and maxFragmentInputComponents should be at least 64.

add_min_limit('maxVertexOutputComponents', 60)
add_min_limit('maxFragmentInputComponents', 60)

@kainino0x kainino0x self-assigned this Dec 21, 2022
@kainino0x
Copy link
Owner

kainino0x commented Dec 21, 2022

You're right, this check predates all the work we did to figure out what we actually needed on Vulkan:
gpuweb/gpuweb#1962 (comment)

Fortunately it doesn't make any difference because the Vulkan spec requires both of these values to be at least 64 anyway:
https://registry.khronos.org/vulkan/specs/1.3-extensions/html/chap45.html#limits-minmax

@teoxoy
Copy link
Collaborator Author

teoxoy commented Dec 21, 2022

Just wanted to make sure it's 1:1 with the spec.

Btw, thanks for putting together this script!
I can imagine it was instrumental for the spec and also quite useful for implementors.

@kainino0x
Copy link
Owner

Glad you appreciate it! It wasn't just me, Corentin did the initial work on it :). It has been and continues to be super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants