Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add a version to cloud-config files #1023

Open
mauromorales opened this issue Mar 2, 2023 · 2 comments
Open

✨ add a version to cloud-config files #1023

mauromorales opened this issue Mar 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@mauromorales
Copy link
Member

Is your feature request related to a problem? Please describe.

If a cloud-config is shared between systems, and those systems are running different versions of the agent, they could possibly not match the schema structure. Since we don't fail for any “extra” keys, this could end up in a situation where the configuration seems to work on both different systems, but it doesn't do the same thing.

Describe the solution you'd like

I'd like to see cloud-configs introduce a version and that such version is a requirement for the cloud-config to be valid e.g.

#cloud-config
version: 1.6.0
users:
  - name: kairos

Describe alternatives you've considered

I think the version as part of the config file is just about standard, but open to any other suggestions

Additional context

n/a

@mauromorales mauromorales added the enhancement New feature or request label Mar 2, 2023
@mauromorales mauromorales assigned mudler and unassigned mudler Mar 2, 2023
@mauromorales mauromorales changed the title ✨ cloud-config files should be versioned ✨ add a version to cloud-config files Mar 2, 2023
@jimmykarily
Copy link
Contributor

This needs some brainstorming. What is the version? The minimum version of kairos-agent you should use with this config? Instruction to kairos-agent to work in "compatibility mode" with that version?

@mauromorales
Copy link
Member Author

Yup agreed, I think the underlying functionality will need some work. I just wanted to put it on an issue to not forget to work on this at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants