Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFs longer than framePreloadCount do not complete after Swift 2.2 syntax update #56

Closed
flyinghyrax opened this issue Apr 4, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@flyinghyrax
Copy link
Contributor

Here is a demo project which exhibits the problem:
https://github.com/mr-seiler/gifu-bug-demo/releases/tag/broken-precache

While working on our fork we've noticed that Gifu would not play through the entirety of a GIF with more frames than the framePreloadCount property of AnimatableImageView.

I used git bisect on a local copy of the repository paired with the demo project linked above and I believe the problem was introduced in the latest commit to master, which contains the updates for the new Swift 2.2 syntax/deprecations. I imagine the problem to be the changes to the Animator class but have not yet confirmed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants