Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super advantage Rolls not displaying the right number on screen when used with Digital Dice + VTT Open #1027

Closed
BatmanJesus4444 opened this issue Oct 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BatmanJesus4444
Copy link

BatmanJesus4444 commented Oct 14, 2022

Describe the bug
When you roll with super advantage, the number displayed in the bottom right isn't the highest, it displays all 3 numbers in the game log and VTT, just not on the bottom left.

Expected behavior
It should display the highest of the three, it doesn't always.

Screenshots
Screenshot (86)

Browser Info (please complete the following information):

  • Chrome
  • Version 106.0.5249.119 (Official Build) (64-bit)
@BatmanJesus4444 BatmanJesus4444 added the bug Something isn't working label Oct 14, 2022
@Aeristoka Aeristoka changed the title Super advantage not displaying the right number on screen Super advantage Rolls not displaying the right number on screen when used with Digital Dice + VTT Open Oct 14, 2022
@Aeristoka Aeristoka added this to the 2.8.0 milestone Oct 14, 2022
@kakaroto
Copy link
Owner

Thanks! Sounds like this is the issue : https://github.com/kakaroto/Beyond20/blob/master/src/dndbeyond/base/digital-dice.js#L127
We always display as the result, the total of the first roll, regardless of whether it was a discarded roll or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants