Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question for the kernel design in multi-batch input. #5

Open
LifeBeyondExpectations opened this issue Jan 14, 2020 · 5 comments
Open

Comments

@LifeBeyondExpectations
Copy link

LifeBeyondExpectations commented Jan 14, 2020

Thank you for your nice work.
Since the code is not yet open, I write down my question for your kernel design.

In the paper, given the image feature information, you set this feature as the convolution weight.
My question is when the size of the batch of the input images is larger than 1, how did you compute the convolution operation?

In pytorch, kernel shape of CNN is [out_channels, in_channels, kernel_size, kernel_size] which means that the same kernels are applied to different multi-batch tensor (e.g. img.shape = [batch, channel, height, width]).
So I guess that you may split the multi-batch-tensor into single-batch-tensor for computation... or did you personally re-implement the convolution operation??..

@LiangliangGuo
Copy link

@LifeBeyondExpectations Have you released the paper successfully?

@JUGGHM
Copy link

JUGGHM commented Mar 3, 2020

Thank you for your nice work.
Since the code is not yet open, I write down my question for your kernel design.
In the paper, given the image feature information, you set this feature as the convolution weight.
My question is when the size of the batch of the input images is larger than 1, how did you compute the convolution operation?
In pytorch, kernel shape of CNN is [out_channels, in_channels, kernel_size, kernel_size] which means that the same kernels are applied to different multi-batch tensor (e.g. img.shape = [batch, channel, height, width]).
So I guess that you may split the multi-batch-tensor into single-batch-tensor for computation... or did you personally re-implement the convolution operation??..

The author claimed that he wrote some CUDA code. I have a reimplemented version of guideconv version using conv and bmm. But I got even worse results with the guideconv fusion blocks than the naïve concatenating strategy. That's weird.

@dv0340
Copy link

dv0340 commented May 17, 2020

@JUGGHM could you please share your code with me ?maybe i can provide some suggestions

@JUGGHM
Copy link

JUGGHM commented Jun 1, 2020

@JUGGHM could you please share your code with me ?maybe i can provide some suggestions

The implemention actually refered to the CSPN naïve implemention by the author of CSPN, and it's easy to understand.

@AlanDecode
Copy link

Hi guys, I've shared my naive implementation based on CSPN in #10, let me known if it helps, or you have any questions or suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants