Calling next_drink results in an error

[andrewladd]

When calling next_drink, I'm greeted by an error related to the usage of the date function:

$ next_drink
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
Next drink at

My solution was changing thirsty.sh's call to the date function like so:

next_drink() {
   next_time=$(($(cat $DRINK_WATER_CONF) + $WATER_TIME))
-  echo "Next drink at $(date --date="@$next_time")"
+  echo "Next drink at $(date -r $next_time)"
 }

Calling next_drink now works:

$ next_drink
Next drink at Sat 25 Feb 2017 18:44:29 EST

Fun script 👍 :)

[kalbhor]

Makes sense, could you send a pull request?

[lfkeitel]

If you would rather me put in a new issue I can.

What version of date are you using and what OS? On my Ubuntu 16.04 machine the -r flag displays the modification time of a file and errors when using the latest commit with this change. If it's an issue with the version of date or the OS there should be some check to determine the correct usage. Here's what date --version outputs for me:

date (GNU coreutils) 8.25
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David MacKenzie.

[andrewladd]

@lfkeitel I'm running MacOS, which likely explains the difference.