Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing scrollbars on long web pages #5

Closed
rogererens opened this issue Nov 23, 2018 · 4 comments
Closed

Missing scrollbars on long web pages #5

rogererens opened this issue Nov 23, 2018 · 4 comments

Comments

@rogererens
Copy link

When the rendered content of a node results in a tall web page, there does not appear a scrollbar in the browser (tested in Chrome and Brave on MS Windows 10) when the View Type (from the hamburger menu in the top right corner) is Outline, Graphic Tree, or Nested Menu. OK though for Inline.
e.g. https://kaleguy.github.io/leovue/#/t/4

image

@kaleguy
Copy link
Owner

kaleguy commented Nov 24, 2018

This is intentional. You'll see that the page will still scroll if you have a scroll wheel or a trackpad, or you can use the arrow keys. (The arrow keys also will move the active item, so you'll need to hold down the Enter key to prevent that behavior).

The scrollbars were removed because they were causing clutter on Windows, which displays large ugly scrollbars. The left pane is particularly clunky looking with scrollbars since there can be bottom and right bars + the divider.

For people without a scroll wheel or trackpad no scrollbars is inconvenient though, so I'll add an option to put the scrollbars back. I'll close this issue once I've added it.

@rogererens
Copy link
Author

I see.
I discovered the scroll wheel behavior accidentally. I don't get your remark wrt the Enter key preventing the arrow key to change the active item selected: whatever I do, upon the key-release (or is it key-up) event the selection switches.

But another (quite important) aspect of scrollbars is that they also give a you visual cue that what is shown of a page in the viewport is not everything of the page.

For example, with my haphazardly chosen window size of the browser, I happened to see this screen shot at first, so it was much later I realized that I had overlooked some info on the page further down:
image

In my opinion, PyCharm keeps the clutter on an acceptable level when scrollbars are shown:
image

So I will be eagerly awaiting the option to enable scrollbars!
Very nice work, BTW :-)

@kaleguy
Copy link
Owner

kaleguy commented Nov 26, 2018

Pycharm's scrollbars are fairly subtle, not so for Windows, especially older versions.

I use a Mac, which hides scrollbars in the browser (unless you are scrolling) so I got used to not using them as a visual cue for extended content.

I realized though, that the problem with the content pane wasn't the scrollbars, it was that they were appearing directly to the right of the centered content, not on the page right. If the vertical scrollbar is all the way to the right, it isn't a problem. So that is what I have implemented now:

  1. Content window gets scrollbar (all the way on right) when content is scrollable.
  2. Treemenu scrollbars remain hidden (otherwise in Windows you get a fat scrollbar next to the divider, which looks clunky. The divider needs to be there because in contrast to other left menu layouts, LeoVue trees can be quite wide so you need to be able to resize the tree menu pane easily.) However, with tree menu should be obvious when there is more content, and can scroll with arrow keys if no wheel or trackpad.

About the arrow keys, I mispoke, the shift key will stop the window from scrolling on Mac but menu item still changes, so can't be used to scroll Content pane.

The changes should be working on main site, but I haven't published to npm yet so they aren't implemented with the CDN version yet. Will publish once I've had a chance to do a bit more testing. Let me know if you see any problems, and thanks for the tip.

@kaleguy
Copy link
Owner

kaleguy commented Nov 27, 2018

Published to 1.17.0, so works on CDN now.

@kaleguy kaleguy closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants