Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support typeguard version 3 #3

Closed
musicinmybrain opened this issue Mar 15, 2023 · 2 comments · Fixed by #4
Closed

Please support typeguard version 3 #3

musicinmybrain opened this issue Mar 15, 2023 · 2 comments · Fixed by #4

Comments

@musicinmybrain
Copy link

Version 3.0.0 of typeguard has been released with breaking changes.

The change that most immediately impacts this package is that the initial argname parameter is removed from typeguard.check_type. This causes quite a few tests to fail (log attached).

If I work around that change (for which I am happy to offer a PR, if you let me know whether you want to maintain backward compatibility with typeguard 2.x or not), I find that there are still quite a few failures (log attached).
@kalekundert kalekundert mentioned this issue Mar 15, 2023
Merged
@kalekundert
Copy link
Owner

Thanks for the heads up. This should be fixed now. I'm actually glad they made that change to typeguard.check_type(); the old API was quite awkward.

@musicinmybrain
Copy link
Author

Thanks; that was fast! Version 1.0.1 is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to typeguard~=3.0 kalekundert/signature_dispatch
2 participants
@kalekundert @musicinmybrain