Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new, probable bugs] detect usage of two or more alphabets in class, NS, etc. names #13

Closed
amoseev opened this issue Oct 31, 2016 · 6 comments

Comments

@amoseev
Copy link

amoseev commented Oct 31, 2016

Hello!

I really enjoyed work with plugin and I advice it for my colleagues, thank a lot!

Recently I accept a mistake. I created a class with name contained Cyrillic and Latin characters.
Can you add functionality with inspection for that case (I suppose for namespaces, classes and method names)?
Or suggest different solution for that case?

Thanks

@kalessil kalessil changed the title Suggestion add inspection like "usage two or more alphabets" [suggestion] detect usage two or more alphabets in class, NS, etc. names Oct 31, 2016
@kalessil
Copy link
Owner

Thank you @amoseev )

I slightly modified the title, this will help me prioritising issues.
Would you please share what happened afterwards (autoloading issues, or something else)?

@amoseev
Copy link
Author

amoseev commented Oct 31, 2016

My task successfully passed all test and checking two QA engineers.
The mistake was disclosed only after deploy on production server.

@kalessil kalessil changed the title [suggestion] detect usage two or more alphabets in class, NS, etc. names [new] detect usage of two or more alphabets in class, NS, etc. names Oct 31, 2016
@kalessil
Copy link
Owner

I see, updated the title. Thank you for details @amoseev .

@kalessil kalessil changed the title [new] detect usage of two or more alphabets in class, NS, etc. names [new, probable bugs] detect usage of two or more alphabets in class, NS, etc. names Oct 31, 2016
@funivan
Copy link
Collaborator

funivan commented Oct 31, 2016

Can you add functionality with inspection for that case (I suppose for namespaces, classes and method names)?

Latest version of the phpstorm PhpStorm 2016.3 EAP (Build #PS-163.6957.13, ) have this feature.
Inspection group called Naming conventions Just add your regexp to the class.

http://imagizer.imageshack.com/img923/3392/hZfvgv.png

Updated:
You can read more about naming convention: https://blog.jetbrains.com/phpstorm/2016/10/phpstorm-2016-3-eap-163-6110/
P.S. Ooops. This feature is available from the 2016.3 EAP 163.6110 build

@kalessil
Copy link
Owner

Cool, thanks for a hint @funivan .

@amoseev
Copy link
Author

amoseev commented Oct 31, 2016

@funivan thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants