fix validation for nested properties #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fixes the issue for you? Can you add a test that is failing without but passing with these change? |
|
No unfortunately not. A console.log shows it can get the correct error messages now, but the ui does not reflect an validation error. |
|
Do you have time to add a failing test? That would help a lot with debugging. |
|
By further investigation, that fix does seem to remove my issue... So think it can be merged as is. |
|
Can you please add a test, which is failing before but passing with this test? This will help us to prevent regressions. |
basz
force-pushed
the
fix/error-for-nested
branch
from
8944dd2
to
8223961
Compare
|
will this be sufficient? |
jelhan
changed the title
|
Looks good to me. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to address #27 (comment)