Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Ember Bootstrap v4.5 and above; drop support for older versions #34

Merged
merged 1 commit into from Dec 4, 2020

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Nov 19, 2020

<BsForm::Element> has been refactored to @glimmer/component in ember-bootstrap/ember-bootstrap#1339. Ember Bootstrap Changeset Validations relies on subclassing <BsForm::Element> and private APIs of it. Therefore it must be adjusted after glimmer component rewrite. This pull requests contain required changes.

It's a breaking change. It won't support older Ember Bootstrap versions anymore.

It should be complete but keep in WIP until ember-bootstrap/ember-bootstrap#1339 is merged. It should be released together with the changes in Ember Bootstrap.

Closes #33 and ember-bootstrap/ember-bootstrap#1280

@jelhan jelhan force-pushed the compatiblity-with-upcoming-ember-bootstrap-version branch from 513c78e to 6b193c7 Compare December 4, 2020 15:04
@jelhan jelhan changed the title WIP: support upcoming Ember Bootstrap release support Ember Bootstrap ^4.5 Dec 4, 2020
@jelhan jelhan changed the title support Ember Bootstrap ^4.5 support Ember Bootstrap v4.5 and above; drop support for older versions Dec 4, 2020
@jelhan
Copy link
Collaborator Author

jelhan commented Dec 4, 2020

ember-canary tests fail with an error that doesn't seem to be related to this change:

             TypeError: registerDestructor is not a function
                at EmberGlimmerComponentManager.createComponent (http://localhost:7357/assets/vendor.js:71352:11)
                at http://localhost:7357/assets/vendor.js:43303:32
                at deprecateMutationsInTrackingTransaction (http://localhost:7357/assets/vendor.js:55795:9)
                at CustomComponentManager.create (http://localhost:7357/assets/vendor.js:43302:64)
                at Object.evaluate (http://localhost:7357/assets/vendor.js:50962:25)
                at AppendOpcodes.evaluate (http://localhost:7357/assets/vendor.js:49320:19)
                at LowLevelVM.evaluateSyscall (http://localhost:7357/assets/vendor.js:52884:22)
                at LowLevelVM.evaluateInner (http://localhost:7357/assets/vendor.js:52840:14)
                at LowLevelVM.evaluateOuter (http://localhost:7357/assets/vendor.js:52832:14)
                at VM.next (http://localhost:7357/assets/vendor.js:54032:24)

CI should allow that scenario to fail. But that doesn't seem to work yet. Will ignore that failing test for now.

@jelhan jelhan merged commit ecf2c4f into master Dec 4, 2020
@simonihmig simonihmig deleted the compatiblity-with-upcoming-ember-bootstrap-version branch April 29, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems to be broken with ember-source >= 3.21.2 and ember-source@3.20.6
1 participant