Adds navbar support #123
Merged
Adds navbar support #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of better ways, tests, and docs to go.
… collapsed state. Need to improve the ergonomics, but it's working correctly now.
…name it internally for simplicity.
…mponents. The resulting currying lets me hide the rest of the plumbing.
…sn't do anything yet.
…sn't do anything yet.
… why the test didn't catch it.
…iciently comprehensive.
|
The ember-cli 2.7.0 upgrade caused some issues that were all over the Slack channel yesterday. Fixed here. |
|
Merged this. Will release this as 0.9.0 asap. Huge thanks for your effort!!! |
This was referenced Aug 13, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #48. It adds a family of bs-navbar* components usable as contextual components under bs-navbar. I have written full documentation, although I have not run the generation from them. I have written integration tests for everything. The acceptance test is not much different from what was generated because I haven't looked into how to trigger responsive behaviors yet. The use of {{hash}} introduces some backward compatibility issues. I believe it was introduced in Ember 2.3 and can be polyfilled back, but I don't know if the same is true of contextual components.