Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in embroider. #1831

Closed
BryanCrotaz opened this issue Nov 9, 2022 · 4 comments
Closed

Doesn't work in embroider. #1831

BryanCrotaz opened this issue Nov 9, 2022 · 4 comments

Comments

@BryanCrotaz
Copy link

BryanCrotaz commented Nov 9, 2022

ember-focus-trap is not imported in a way that embroider understands. In embroider you get a module not found error.

Module not found: 
Error: Can't resolve 'ember-focus-trap/modifiers/focus-trap.js' in 
'$TMPDIR/embroider/e41e4f/modifiers/focus-trap.js'
@ef4
Copy link
Contributor

ef4 commented Nov 10, 2022

ember-bootstrap's CI is green under Embroider so something more must be required to make this fail.

@ef4
Copy link
Contributor

ef4 commented Nov 10, 2022

@BryanCrotaz
Copy link
Author

I reproduced it like this:

  1. ember new my-app, cd my-app
  2. ember install @html-next/vertical-collection
  3. move to using embroider
  4. yarn add ember-bootstrap
  5. ember s
    module not found: ember-focus-trap

@ef4
Copy link
Contributor

ef4 commented Nov 10, 2022

I confirmed that this is definitely the same as embroider-build/embroider#1175, so this issue on ember-bootstrap can probably be closed. The addon isn't doing anything wrong, it's an embroider bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants