Fix CI config for running FastBoot tests #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was intended before to run FastBoot tests only within the explicit ember-try scenario, but actually they did run for every scenario. This should fix it. However we may revise that later, as FastBoot tests using `ember-cli-fastboot-testing` don't suffer from the overhead they had before. But we should do that eventually only after glimmerjs/glimmer-vm#1141 is fixed, which currently causes FastBoot tests to fail for Ember beta/canary.
simonihmig
force-pushed
the
fix-fastboot-tests
branch
from
cde1538
to
477e08c
Compare
simonihmig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was intended before to run FastBoot tests only within the explicit ember-try scenario, but actually they did run for every scenario. This should fix it.
However we may revise that later, as FastBoot tests using
ember-cli-fastboot-testingdon't suffer from the overhead they had before. But we should do that eventually only after glimmerjs/glimmer-vm#1141 is fixed, which currently causes FastBoot tests to fail for Ember beta/canary.