Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix usage example in accordion docs #1257

Merged
merged 1 commit into from Sep 23, 2020
Merged

fix usage example in accordion docs #1257

merged 1 commit into from Sep 23, 2020

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Sep 23, 2020

  • The yielded object was named Acc but used as acc.change.
  • Most of our documentation and ember ecosystem is using lowercase variables only.
  • Replaced onclick property with {{on}} modifier.
  • Replaced {{action}} helper with {{fn}} helper.

simonihmig
simonihmig approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simonihmig simonihmig merged commit 5b2f8d0 into master Sep 23, 2020
@simonihmig simonihmig deleted the improve-accordion-documentation branch September 23, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonihmig simonihmig simonihmig approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jelhan @simonihmig