<BsForm::Element> should respect @value argument #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1339 refactored
<BsForm::Element>from@ember/componentto@glimmer/component. For a@ember/componentsetting the@valueargument executed thevaluesetter of the component. But this is not the case anymore after changing to@glimmer/component. Therefore the component was not using the@valueargument anymore at all.The good thing is that keeping a local copy of the state it is not needed anymore at all. As argument and component property is decoupled by
@glimmer/componentwe can handle all cases in the getter.Thanks a lot to @lindyhopchris for providing the failing test.
Closes #1403 and #1404