Support switch control in forms (BS4 only) #1495
Conversation
|
FYI I couldn't preview the changes to the docs site as it's not working when I run |
There was a problem hiding this comment.
Thanks a lot for working on this. Haven't had the time yet to do a detailed review. But what I have seen so far looks very good to me. Will try to finish review later today.
FYI I couldn't preview the changes to the docs site as it's not working when I run
ember slocally in the docs folder - getting an error.
The docs site is broken since quiet some time. 😞 See #1387 for details.
tests/integration/components/bs-form/element/control/switch-test.js
Outdated
Show resolved
Hide resolved
jelhan
changed the title
|
@jelhan thanks for reviewing. I'll make those changes to the test when I get a chance (hopefully later today) |
addon/components/bs-form/element/layout/horizontal/checkbox.hbs
Outdated
Show resolved
Hide resolved
simonihmig
changed the title
|
@simonihmig thanks for your comments! All make sense, so I'll be able to push an update. Today is looking busy so hopefully I'll have time tomorrow. |
|
I've pushed the changes based on the review comments, so this should now be ready to merge. Do you need me to fix the merge conflicts? I tried back merging |
Yes, unfortunately I cannot merge it with this conflict. I did a few things here yesterday, so sorry for causing this additional work! 😔
Hm, what exactly was the error? Did you update your dependencies and restarted |
|
@simonihmig have pushed the merge fix. Turned out the failing tests were due to a bad merge on my part, re-did the merge and worked out how to fix it, so all should be good now. |
Adds a
switchcontrol type, for the Bootstrap 4 switch custom control type:https://getbootstrap.com/docs/4.6/components/forms/#switches
See #912