Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bootstrap5 in default blueprint #1497

Merged
merged 2 commits into from May 13, 2021
Merged

Support Bootstrap5 in default blueprint #1497

merged 2 commits into from May 13, 2021

Conversation

simonihmig
Copy link
Contributor

@simonihmig simonihmig commented May 13, 2021 •
edited

Will update the setup guide later when the docs app is fixed...

@simonihmig simonihmig changed the title Support Bootstrap5 ind default blueprint Support Bootstrap5 in default blueprint May 13, 2021
@simonihmig simonihmig mentioned this pull request May 13, 2021
Closed
16 tasks
jelhan
jelhan approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot for pushing Bootstrap 5 support.

Do you know why the files haven't been prettified before?

@simonihmig
Copy link
Contributor Author

Do you know why the files haven't been prettified before?

The folders had a local .eslintrc.js, which seems to have disabled the prettier linting effectively. So that's why the "wrongly" formatted files never caused linting errors. I removed those config files in this PR.

@simonihmig simonihmig merged commit f3c30e5 into master May 13, 2021
@simonihmig simonihmig deleted the bs5-blueprint branch May 13, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
Bootstrap 5 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonihmig @jelhan