Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltips and Popovers for Bootstrap 5 #1502

Merged
merged 3 commits into from May 18, 2021
Merged

Conversation

simonihmig
Copy link
Contributor

No description provided.

@simonihmig
Copy link
Contributor Author

This is pretty weird. The arrow positioning tests fail here for BS5, although they do pass locally (both ember serve and ember test).

Even more weird, is that these tests do pass in CI for Ember release scenario, but fail for all others. I can't even see how the Ember version can cause this.

And basically impossible to debug, when not reproducible locally. At least a screenshot of the test container would be helpful... 😩

@simonihmig
Copy link
Contributor Author

Hm, ember-release passes because it runs with Firefox. The CI setup is not quite right here, we don't run ember-release in Chrome...

@simonihmig simonihmig force-pushed the bs5-tooltips branch 3 times, most recently from 3ee56cd to 116f2f4 Compare May 17, 2021 21:08
@simonihmig
Copy link
Contributor Author

Finally CI is passing, by making thee target element have a fixed width. Not sure what was making the tests fail only in CI, but as these were some of the very few tests that assert the actual styling and layout, it could be for example some different font rendering under Linux that would cause the target element (a button) to have (slightly) different dimensions affecting the positioning of the actual popover/tooltip.

@simonihmig simonihmig merged commit 8401113 into master May 18, 2021
@simonihmig simonihmig deleted the bs5-tooltips branch May 18, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant