Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .collapsed markup for accordions #1590

Merged
merged 2 commits into from Aug 13, 2021
Merged

Conversation

simonihmig
Copy link
Contributor

Extracted the bug fix from #1561

@simonihmig
Copy link
Contributor Author

@jelhan do you want to / have the time to review this? I think this should not be very controversial, just a lot of noise in the tests diff. So if you don't have the time, then I would like to move this forward quickly nevertheless, also as it blocks #1561...

Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'm just a little bit confused that I haven't found .expanded class in BS3 nor BS4 docs. Are you sure that class is needed? Or is that maybe another big?

@simonihmig
Copy link
Contributor Author

I'm just a little bit confused that I haven't found .expanded class in BS3 nor BS4 docs. Are you sure that class is needed? Or is that maybe another big?

Hm, I wasn't aware tbh. Probably something along the lines of #1261, where some classes were added for convenience (e.g. styling an expanded item specifically, without putting the styles into all items, and overriding them for .collapsed). But I think we can remove that in v5 if we want. All supported browsers will then also support :not()...

@simonihmig simonihmig merged commit a1f04de into master Aug 13, 2021
@simonihmig simonihmig deleted the fix-accordion-markup branch August 13, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants