Remove use of curly component invocation for link components #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should officially drop support for any curly component invocation in v5. A short note in the changelog should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to support curly invocation of
LinkTo, so removing tests. Also(query-params)helpers seems to be dropped from Ember 4, so this is helping to get CI green again.I think the change is fine, so I'll merge without review. The question is if we want to tag this PR as breaking? After all the yielded link-to components use Ember's original one, which is not supposed to be used with curlies anyway. Do we actually consider any use of curly invocation still supported (as long as Ember supports it? @jelhan thoughts?