Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition/readonly attribute #172

Merged
merged 4 commits into from Dec 3, 2016

Conversation

basz
Copy link
Contributor

@basz basz commented Dec 1, 2016

This PR adds support for the readonly attribute, which differs from the disabled attribute

  • A read-only field can't be modified, but, unlike disabled, you can tab into it, highlight it, and copy its contents.
  • readonly is only relevant for type text, search, url, tel, email, number, password, and the date/time input types. It is also valid on <textarea>
  • readonly is ignored for type hidden, range, color, checkbox, radio, file, button, submit and image

@simonihmig
Copy link
Contributor

Looks good in general! But you have modified the template for the select element only for the vertical form layout, not horizontal and inline. Probably forgotten?

@basz
Copy link
Contributor Author

basz commented Dec 2, 2016

That must be a mistake - select does not support read only anyway and its deprecated afaik.

Ill fix that soon

@simonihmig simonihmig merged commit dec8e8c into ember-bootstrap:master Dec 3, 2016
@simonihmig
Copy link
Contributor

@basz Thanks a lot for this contribution! 👍

@basz
Copy link
Contributor Author

basz commented Dec 3, 2016

You are welkome! Thanks for merging!

@basz basz deleted the addition/readonly-attribute branch September 22, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants