Convert to v2 addon #324
Convert to v2 addon #324
Conversation
# Conflicts: # package.json # yarn.lock
| { | ||
| "plugins": [ | ||
| ["@babel/plugin-proposal-decorators", { "legacy": true }], | ||
| "@babel/plugin-proposal-class-properties", |
There was a problem hiding this comment.
Was there something that breaks if you don't transpile the class properties and decorators? I wouldn't have expected you to need these two plugins.
There was a problem hiding this comment.
Ah, thanks for reviewing @ef4! And yes, this is an excellent point you raise here. I already thought about getting in touch with you on this, or filing an issue in the babel repo. I did try to leave decorators untranspiled, as that is supported by your definition of the Ember Language Standard. But indeed I failed to do so, so to unblock my effort I went for transpilation for now.
I first tried to only add @babel/plugin-syntax-decorators. The first paragraph suggests this will allow babel to parse decorators, but not transpile them, so just what we need:
It's unlikely you want to use this plugin directly as it only enables Babel to parse this syntax. Instead, use plugin-proposal-decorators to both parse and transform this syntax.
But this did not work. Babel still failed with some error, related to an unexpected @ syntax. I would have to try it again to get the exact error message.
Have you managed somewhere to get that use case working, i.e. let babel do all the transformation you want but leave decorators in place?
No description provided.