Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing timer changes in message history #47

Closed
BaeoMaltinsky opened this issue Oct 30, 2019 · 3 comments
Closed

Disappearing timer changes in message history #47

BaeoMaltinsky opened this issue Oct 30, 2019 · 3 comments
Labels
Discussion Proposed implementations, thoughts about current ones.

Comments

@BaeoMaltinsky
Copy link
Collaborator

I'm inclined to make this a UI detail rather than a persistent feature of a linear message history. If you have secrets worth hiding, then not having a record of having turned them on or off seems correct.

If we go this route, this can stay confined to libherald, if we don't and make them persistent, then there are a number of questions I would like to have answered about how these are going to be handled (e.g., are these events searchable in the global message search).

@BaeoMaltinsky BaeoMaltinsky created this issue from a note in Message types (Types) Oct 30, 2019
@BaeoMaltinsky BaeoMaltinsky added the Discussion Proposed implementations, thoughts about current ones. label Oct 30, 2019
@BaeoMaltinsky BaeoMaltinsky changed the title Notifications for disappearing timer Disappearing timer changes in message history Oct 30, 2019
@GallagherCommaJack
Copy link
Collaborator

Any persistent record of deleted messages is something we should avoid wherever possible.

@colleenm
Copy link
Collaborator

Agree with Jack, I prefer no record in message history.

I don't know what "make this a UI detail means"--do you mean we only show what the current timer setting is set to somewhere in the client UI? (That's what I think we should do)

@kaavyajayram
Copy link
Collaborator

++ Changes regarding expiring message disappear with the messages

@BaeoMaltinsky BaeoMaltinsky removed this from Types in Message types Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Proposed implementations, thoughts about current ones.
Projects
None yet
Development

No branches or pull requests

4 participants